Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding missing shardSize parameter to MatchingEngineIndexConfig #3251

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nsosa-um
Copy link

This Pull Request addressed issue reported here: #3250

"When creating an index with Vector Search, python sdk is missing the parameter shardSize on the class MatchingEngineIndexConfig, which makes impossible to create an index with a different shard size using this sdk."

Copy link

google-cla bot commented Jan 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

conventional-commit-lint-gcf bot commented Jan 29, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jan 29, 2024
@nsosa-um nsosa-um changed the title feature: adding missing shardSize parameter to MatchingEngineIndexConfig feat: adding missing shardSize parameter to MatchingEngineIndexConfig Jan 29, 2024
…addding shardSize parameter to MatchingEngineIndexConfig
@nsosa-um nsosa-um force-pushed the feature/adding-missing-index-config-vectorsearch branch from ecef875 to cbe6b49 Compare January 29, 2024 19:21
nsosa-um and others added 3 commits January 30, 2024 09:28
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants