Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra_environment_variables param to LocalModel.build_cpr_model() #1833

Open
MichaelisTrofficus opened this issue Dec 7, 2022 · 2 comments · May be fixed by #1832
Open

Add extra_environment_variables param to LocalModel.build_cpr_model() #1833

MichaelisTrofficus opened this issue Dec 7, 2022 · 2 comments · May be fixed by #1832
Assignees
@kthytang
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@MichaelisTrofficus
Copy link

Currently, the build_cpr_model() method of the LocalModel class does not allow environment variables to be passed in a simple way.

I've creare a PR to add an extra_environment_variables parameter, where we can define the environment variables we want to use in our CPR. A very useful use can be to set the VERTEX_CPR_WEB_CONCURRENCY variable, and thus control the number of workers that are raised in the Endpoint.

PR: #1832
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label Dec 7, 2022
@MichaelisTrofficus MichaelisTrofficus linked a pull request Dec 7, 2022 that will close this issue
Open
6 tasks
@rosiezou rosiezou self-assigned this Dec 14, 2022
@MichaelisTrofficus
Copy link
Author

Are there any updates in relation to this feature?

@rosiezou
Copy link
Contributor

rosiezou commented Jan 3, 2023

I am reaching out to our backend teams to double-check that this change aligns with the intended behavior of this method. Once I hear back from them I will proceed with the rest of the PR review.

@sasha-gitg sasha-gitg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 18, 2023
@rosiezou rosiezou assigned kthytang and unassigned rosiezou Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kthytang kthytang

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
4 participants
@kthytang @rosiezou @MichaelisTrofficus @sasha-gitg