chore: Add logging when deleting agent engine resource

PiperOrigin-RevId: 816278193

Author: yeesian

tests/unit/vertexai/genai/replays/test_delete_agent_engine.py

@@ -14,17 +14,21 @@
 #
 # pylint: disable=protected-access,bad-continuation,missing-function-docstring
 
+import logging
 import pytest
 
 
 from tests.unit.vertexai.genai.replays import pytest_helper
 from vertexai._genai import types
 
 
-def test_agent_engine_delete(client):
+def test_agent_engine_delete(client, caplog):
+    caplog.set_level(logging.INFO)
     agent_engine = client.agent_engines.create()
     operation = client.agent_engines.delete(name=agent_engine.api_resource.name)
     assert isinstance(operation, types.DeleteAgentEngineOperation)
+    assert "Deleting AgentEngine resource" in caplog.text
+    assert f"Started AgentEngine delete operation: {operation.name}" in caplog.text
 
 
 pytestmark = pytest_helper.setup(
@@ -38,10 +42,13 @@ def test_agent_engine_delete(client):
 
 
 @pytest.mark.asyncio
-async def test_agent_engine_delete_async(client):
+async def test_agent_engine_delete_async(client, caplog):
+    caplog.set_level(logging.INFO)
     # TODO(b/431785750): use async methods for create() when available
     agent_engine = client.agent_engines.create()
     operation = await client.aio.agent_engines.delete(
         name=agent_engine.api_resource.name
     )
     assert isinstance(operation, types.DeleteAgentEngineOperation)
+    assert "Deleting AgentEngine resource" in caplog.text
+    assert f"Started AgentEngine delete operation: {operation.name}" in caplog.text

tests/unit/vertexai/genai/test_agent_engines.py

@@ -2271,7 +2271,7 @@ def teardown_method(self):
 
     def test_delete_agent_engine(self):
         with mock.patch.object(
-            self.client.agent_engines._api_client, "async_request"
+            self.client.aio.agent_engines._api_client, "async_request"
         ) as request_mock:
             request_mock.return_value = genai_types.HttpResponse(body="")
             asyncio.run(
@@ -2288,7 +2288,7 @@ def test_delete_agent_engine(self):
 
     def test_delete_agent_engine_force(self):
         with mock.patch.object(
-            self.client.agent_engines._api_client, "async_request"
+            self.client.aio.agent_engines._api_client, "async_request"
         ) as request_mock:
             request_mock.return_value = genai_types.HttpResponse(body="")
             asyncio.run(

vertexai/_genai/agent_engines.py

@@ -318,7 +318,7 @@ def _create(
         self._api_client._verify_response(return_value)
         return return_value
 
-    def delete(
+    def _delete(
         self,
         *,
         name: str,
@@ -725,6 +725,34 @@ def get(
             self._register_api_methods(agent_engine=agent_engine)
         return agent_engine
 
+    def delete(
+        self,
+        *,
+        name: str,
+        force: Optional[bool] = None,
+        config: Optional[types.DeleteAgentEngineConfigOrDict] = None,
+    ) -> types.DeleteAgentEngineOperation:
+        """
+        Delete an Agent Engine resource.
+
+        Args:
+            name (str):
+                Required. The name of the Agent Engine to be deleted. Format:
+                `projects/{project}/locations/{location}/reasoningEngines/{resource_id}`
+                or `reasoningEngines/{resource_id}`.
+            force (bool):
+                Optional. If set to True, child resources will also be deleted.
+                Otherwise, the request will fail with FAILED_PRECONDITION error when
+                the Agent Engine has undeleted child resources. Defaults to False.
+            config (DeleteAgentEngineConfig):
+                Optional. Additional configurations for deleting the Agent Engine.
+
+        """
+        logger.info(f"Deleting AgentEngine resource: {name}")
+        operation = self._delete(name=name, force=force, config=config)
+        logger.info(f"Started AgentEngine delete operation: {operation.name}")
+        return operation
+
     def create(
         self,
         *,
@@ -1659,7 +1687,7 @@ async def _create(
         self._api_client._verify_response(return_value)
         return return_value
 
-    async def delete(
+    async def _delete(
         self,
         *,
         name: str,
@@ -1994,6 +2022,34 @@ async def _update(
     _memories = None
     _sessions = None
 
+    async def delete(
+        self,
+        *,
+        name: str,
+        force: Optional[bool] = None,
+        config: Optional[types.DeleteAgentEngineConfigOrDict] = None,
+    ) -> types.DeleteAgentEngineOperation:
+        """
+        Delete an Agent Engine resource.
+
+        Args:
+            name (str):
+                Required. The name of the Agent Engine to be deleted. Format:
+                `projects/{project}/locations/{location}/reasoningEngines/{resource_id}`
+                or `reasoningEngines/{resource_id}`.
+            force (bool):
+                Optional. If set to True, child resources will also be deleted.
+                Otherwise, the request will fail with FAILED_PRECONDITION error when
+                the Agent Engine has undeleted child resources. Defaults to False.
+            config (DeleteAgentEngineConfig):
+                Optional. Additional configurations for deleting the Agent Engine.
+
+        """
+        logger.info(f"Deleting AgentEngine resource: {name}")
+        operation = await self._delete(name=name, force=force, config=config)
+        logger.info(f"Started AgentEngine delete operation: {operation.name}")
+        return operation
+
     @property
     def memories(self):
         if self._memories is None: