-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate proto-plus types for this library #42
Comments
Sounds like the right direction to me. For clarity, will this be a breaking change for this package only, or will also require a break in Cloud Asset? A break here only seems fine, but google-cloud-asset is published stable so we should think more about that if necessary. |
Now that I think about this more some Will hold on this for now, and address when/if a service is created for Access Context Manager. |
@busunkim96 A service appears to be available for the v1 client here. Googlers see b/187964157. |
👍 let's discuss how to proceed tomorrow. |
@busunkim96 Please could you take a look? |
This library currently generates
_pb2.py
types via protoc.I would like to move this set of protos to be generated via bazel. The repository will look like a full GAPIC library but only have types (no services). If Access Context Manager adds a service in the future the change will be additive (non-breaking). See this repo for an example of the desired end state.
This is a breaking change, but I believe the blast radius will be small - this library is only installed as a dependency of
google-cloud-asset
(see setup.py).CC @parthea @danoscarmike
The text was updated successfully, but these errors were encountered: