Skip to content

feat: add support for matchGlob list option #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddelgrosso1 merged 1 commit into from
Jun 2, 2023
Merged

feat: add support for matchGlob list option #2206

ddelgrosso1 merged 1 commit into from
Jun 2, 2023

Conversation

@ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented May 31, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2205 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners May 31, 2023 14:09
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 31, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@ddelgrosso1 ddelgrosso1 requested a review from JesseLovelace May 31, 2023 14:17
@ddelgrosso1 ddelgrosso1 merged commit 79dd839 into googleapis:main Jun 2, 2023
@release-please release-please bot mentioned this pull request Jun 2, 2023
Merged
@punehim punehim mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for matchGlob list option

3 participants

@ddelgrosso1 @danielbankhead @JesseLovelace