Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Fix param descriptions for filters #1346

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cindy-peng
Copy link

Fix issue the returns value doesn't contain a description. The fix is to add a description.

Link to Example: https://cloud.google.com/nodejs/docs/reference/datastore/latest/overview#_google_cloud_datastore_and_function_1_

@cindy-peng cindy-peng requested review from a team as code owners October 29, 2024 22:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/nodejs-datastore API. labels Oct 29, 2024
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run the linter and then this should be good to go.

src/filter.ts Outdated Show resolved Hide resolved
src/filter.ts Outdated Show resolved Hide resolved
@cindy-peng
Copy link
Author

linter

Hi Dan, do you know how can I run the linter?

@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2024
@cindy-peng
Copy link
Author

/gcbrun

@cindy-peng cindy-peng closed this Nov 6, 2024
@cindy-peng cindy-peng reopened this Nov 6, 2024
@kevkim-codes kevkim-codes added the automerge Merge the pull request once unit tests and other checks pass. label Nov 8, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants