-
Notifications
You must be signed in to change notification settings - Fork 106
Comparing changes
Open a pull request
base repository: googleapis/nodejs-datastore
base: v8.0.0
head repository: googleapis/nodejs-datastore
compare: v8.1.0
- 7 commits
- 27 files changed
- 6 contributors
Commits on Aug 15, 2023
-
test: disable retry-request for streaming tests (#1127)
* fix: fix typings for IAM methods docs: fixed links in the generated Markdown documentation PiperOrigin-RevId: 551610576 Source-Link: googleapis/googleapis@73b1313 Source-Link: googleapis/googleapis-gen@8bec066 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGJlYzA2NjQ5MmE2ZGEyODU1YjFiOGNlNTYyNjY0YzBhNmIzMGIwMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Specify limit for `properties` in `Index` message in Datastore Admin API docs: Minor formatting in Datastore Admin API PiperOrigin-RevId: 551819875 Source-Link: googleapis/googleapis@3db8b01 Source-Link: googleapis/googleapis-gen@7ebf113 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2ViZjExMzc2MzliOTM2MTNlNmE2MjA2NjU0YTViYThmMjFlOTMyMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: publish proto definitions for SUM/AVG in Datastore PiperOrigin-RevId: 552847139 Source-Link: googleapis/googleapis@6148e5b Source-Link: googleapis/googleapis-gen@96be51b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTZiZTUxYjk5NTA0N2JmZGVmNDgyNTE3ODUzOWUyMzg1ODMxMDFhOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: disable retry-request for streaming tests PiperOrigin-RevId: 554648220 Source-Link: googleapis/googleapis@53cd9ad Source-Link: googleapis/googleapis-gen@7e8867e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2U4ODY3ZWZiZWQ3ZGJmZTVlZjZlYzNjMmM5MmE0YmNlNDI4MGY3YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b13ecfc - Browse repository at this point
Copy the full SHA b13ecfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7c3aaf - Browse repository at this point
Copy the full SHA e7c3aafView commit details
Commits on Sep 1, 2023
-
feat: Sum and average aggregation queries (#1097)
* Initial sum aggregation This commit introduces the sum aggregation with a simple test to ensure it works * Modify encoding This change modifies the encoding so that the right data reaches the grpc layer * PropertyAggregateField with tests Adds helper functions and a super class so that average and sum can share the same properties. * Improve transaction tests Add sum and average to the transaction tests here to improve test coverage for transactions. * Change the description in the describe block * Change return type to average The return type for this function is wrong. The function returns an Average so we should use Average. * Make alias optional Make alias optional since the query still works without providing an alias. * Fix the transaction tests to fail on rollback The transaction tests should not pass if the transaction is rolled back like they do currently. We must not catch errors and instead let the test fail. * Add additional assertions to existing tests Ensure that the addAggregation function works correctly with an additional assertion check. * Revert "Add additional assertions to existing tests" This reverts commit 970c0f4. * Add describe block for comparing equivalent query This test ensures that all the aggregate queries are actually the same no matter how you build them * Average, sum and count toProto tests Write tests to effectively document the toProto output of the various aggregate fields * Add tests for the sum aggregation Equivalent tests to count are written for sum in system tests and some more tests are written too to meet requirements outlined by team. * Add a test for sum and snapshot reads The test for sum and snapshot reads should look at the database before the data is created and run the tests based on the database in that state * Add two test blocks for special cases Add a test block for a dataset with overflow values and a dataset with NaN values. * Export aggregate field from the client Aggregate field should be exported from the client so that it can be used easily by users. * PR follow-up changes Some idiomatic changes to improve the state of the code in the PR. * Adjust the values so that tests pass Values for sum and average should be different from those of count and these tests provide the right values now. # Conflicts: # system-test/datastore.ts * Add average aggregations Average aggregations regarding appearances have been added in tests and correct values have been assigned * Add snapshot reads for run query and aggregate q The future refactor must implement the TODOs so that there is less repeated code in the codebase. Also, this commit implements snapshot reads for queries and adds a test for the snapshot reads. * Remove Google error and entity filter Remove some unused imports as they do not apply to the code anymore * Should use null for an aggregation query read time Snapshot reads read at a time that there is no data so sums and averages should reflect that accordingly. * Remove tests from a bad cherry pick Tests for sum that have values corresponding to count are still there in the test cases. They should be removed. * Linting fix We don’t care about a loss of precision since the literal value indicated is contained in a test and the loss of precision won’t affect the code. * Do the test on rating instead of appearances At this point the datastore is populated with data about ratings so computations should be done on that instead. * The assertion says the request should have failed An assertion error should be thrown so that the test doesn’t pass if the request is successful. * Add a comment about using limits in test The query with the limit will include all data points with the lowest appearance values. This is likely desired, but also important to document. * Add rollbacks to transaction tests The rollbacks for the transaction tests ensure that if a test fails then the data gets reset to where it was before. * refactor getSharedOptionsOnly Introducing getSharedOptionsOnly allows us to use that function in two different places to avoid a repeated block of code. * Remove test related to snapshot reads This test belongs inside another PR because it is not directly related to sum/avg. * Add a test for multiple types of aggregates A test should be included that looks at multiple aggregations in a single query. * Correct descriptions of two tests on overflow The tests themselves should include the word overflow so that it is clear they are working with an overflow dataset. * Add a comment for setting the alias The comment for setting the alias should not make any mention of count since it is agnostic to the aggregation type. * Add tests to compare various ways to encode alias No matter how alias is encoded, the data structures should store the aggregations the same way inside an aggregate field so as not to create any confusion. * Added tests for when an empty alias is provided Tests for when an empty alias is provided should check that each aggregate query still works. * Add a comment clarifying the use of snapshot reads The sleep function should enable us to test snapshot reads for aggregate queries * Add two tests to explore mixed aggregations alias Two tests should be explored that evaluate what happens when multiple aggregations are used and when too many aggregations are used. * Better names for some internal private functions Shared options functions could be given a better name so that they make more sense to the code that is using them. * Add a comment explaining why the sleep is needed The code must explain why the sleep function is needed in the test because its purpose should be clear. * Add getReadTime function and use for sum/avg A sum/average test uses snapshot reads for an aggregate query. The key here is write code that will guarantee the read time occurs well before all the data is saved in order to ensure the test isn’t flakey. * Rename variable to emptyData emptyData is a more accurate variable name for the datastore save data
Configuration menu - View commit details
-
Copy full SHA for 44ba6f8 - Browse repository at this point
Copy the full SHA 44ba6f8View commit details
Commits on Sep 7, 2023
-
chore(deps): update actions/checkout action to v4 (#1146)
* chore(deps): update actions/checkout action to v4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2a5d5b9 - Browse repository at this point
Copy the full SHA 2a5d5b9View commit details -
chore(deps): update actions/checkout action to v4 (#1147)
* chore(deps): update actions/checkout action to v4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b25537d - Browse repository at this point
Copy the full SHA b25537dView commit details -
fix: simplify logic for HTTP/1.1 REST fallback option (#1138)
* docs: Update property requirement specifications PiperOrigin-RevId: 557861399 Source-Link: googleapis/googleapis@3303b93 Source-Link: googleapis/googleapis-gen@fb0d0a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmIwZDBhNDUzODVlYjBiZTU4NDIxMTFhZjc5YWY1ZDcxOWQzMjE2OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: simplify logic for HTTP/1.1 REST fallback option For the `fallback` parameter, all values considered as `true` in Boolean context will enable HTTP/1.1 REST fallback, since the other fallback transport, proto over HTTP, is removed from `google-gax` v4. PiperOrigin-RevId: 559812260 Source-Link: googleapis/googleapis@6a6fd29 Source-Link: googleapis/googleapis-gen@56c1665 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTZjMTY2NTdlN2E1OTEyMmIxZGE5NDc3MWE5ZWY0MDk4OWMyODJjMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4cefaea - Browse repository at this point
Copy the full SHA 4cefaeaView commit details
Commits on Sep 13, 2023
-
chore(main): release 8.1.0 (#1145)
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1446d7f - Browse repository at this point
Copy the full SHA 1446d7fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.0.0...v8.1.0