Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/install-without-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<maven.compiler.source>1.8</maven.compiler.source>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<opencensus.version>0.31.1</opencensus.version>
<trace.version>2.79.0</trace.version>
<trace.version>2.80.0</trace.version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This update to trace.version is not consistently applied across the repository. The google-cloud-spanner/pom.xml file still uses older, hardcoded versions for trace-related test dependencies:

  • google-cloud-trace is at version 2.76.0.
  • proto-google-cloud-trace-v1 is at version 2.79.0.

Since google-cloud-trace:2.80.0 depends on proto-google-cloud-trace-v1:2.80.0, this version mismatch can lead to classpath conflicts and makes the project harder to maintain.

To ensure consistency, I recommend updating these dependencies in google-cloud-spanner/pom.xml as well. Ideally, these versions should be managed in the root pom.xml's <dependencyManagement> section to avoid such issues in the future.

<cloudmonitoring.version>3.77.0</cloudmonitoring.version>
</properties>

Expand Down
2 changes: 1 addition & 1 deletion samples/snapshot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<maven.compiler.source>1.8</maven.compiler.source>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<opencensus.version>0.31.1</opencensus.version>
<trace.version>2.79.0</trace.version>
<trace.version>2.80.0</trace.version>
<cloudmonitoring.version>3.77.0</cloudmonitoring.version>
</properties>

Expand Down