feat: Add the checkpoint and serializer for the split enumerator #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
| @Override | ||
| public SplitEnumeratorCheckpoint deserialize(int i, byte[] bytes) throws IOException { | ||
| return SplitEnumeratorCheckpoint.parseFrom(bytes); | ||
| } |
Contributor
There was a problem hiding this comment.
mind just making one of these for protos? "BackwardsCompatibleProtoSerializer"
Contributor
Author
There was a problem hiding this comment.
I spent a bit trying to do this. It sounds like the right thing to do, but the results weren't great.
We end up needing two deserializers anyway because SubscriptionPartitionSplit (the other type needing a serializer) isn't a proto, it's just serialized using a proto, so you end up with a serializer that takes a proto serializer and proxies.
Also type erased generics make the implementation awkward because you have to pass ProtoType::parseFrom into the generic proto serializer constructor as a lambda.
I think this is simpler as is
dpcollins-google
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️