This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
fix: make java.base fields accessible to fix java 17 runtime errors. #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: oslogin
Issues related to the googleapis/java-os-login API.
labels
May 31, 2022
Now resulting in the following error locally:
This could be a result of some missing integration test setup on local machine. Testing on the CI. |
On the CI, we are running into:
|
mpeddada1
changed the title
fix: java 17 reflection issue
fix: make java.base fields accessible to fix java 17 runtime errors.
May 31, 2022
All checks are now passing. |
suztomo
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.0...v2.2.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([#694](#694)) ([a72656a](a72656a)) ### Bug Fixes * make java.base fields accessible to fix java 17 runtime errors. ([#688](#688)) ([b262f13](b262f13)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#693](#693)) ([22bd8a0](22bd8a0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/java-os-login@v2.1.0...v2.2.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#694](googleapis/java-os-login#694)) ([a82410e](googleapis/java-os-login@a82410e)) ### Bug Fixes * make java.base fields accessible to fix java 17 runtime errors. ([googleapis#688](googleapis/java-os-login#688)) ([51a9a6f](googleapis/java-os-login@51a9a6f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#693](googleapis/java-os-login#693)) ([ecb4469](googleapis/java-os-login@ecb4469)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: oslogin
Issues related to the googleapis/java-os-login API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #687