chore: ensure that transitive deps have the latest version selected #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
elharo
reviewed
Feb 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
============================================
+ Coverage 82.23% 82.25% +0.01%
Complexity 983 983
============================================
Files 99 99
Lines 6040 6040
Branches 332 332
============================================
+ Hits 4967 4968 +1
+ Misses 896 895 -1
Partials 177 177
Continue to review full report at Codecov.
|
kolea2
approved these changes
Feb 25, 2020
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mitigate diamond dependency issues.
Gradle and maven have different behaviors when resolving transitive dependency version conflicts. Gradle selects the greatest version, while maven picks the closest in the dependency hierarchy. For example:
Say http-client and google-auth-library pull in different versions of Apache commons logging at the same depth. Then which one your project gets depends on whether you depend on http-client first and google-auth-library second or vice versa.
This PR enforces that the resolution behavior remains consistent and will break the build.
Fixes issues like googleapis/google-http-java-client#981