Skip to content

Commit ae7b9d8

Browse files
deps: upgrade java-bigtable to 2.44.1 (#4445)
* deps: upgrade java-bigtable to 2.44.1 Change-Id: I8b3bcbd2ad6398dc67517ad6cbaef9d080022a37 * format Change-Id: I88fae43328ec6e437468db1aefd7dd3f4a34ef11 * fix shading Change-Id: I591d5a737828b39f857647dc5478fd558e2e1473
1 parent 782b39c commit ae7b9d8

File tree

5 files changed

+41
-17
lines changed

5 files changed

+41
-17
lines changed

bigtable-client-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/BigtableHBaseVeneerSettings.java

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,16 @@ private BigtableDataSettings buildBigtableDataSettings(ClientOperationTimeouts c
298298
int port = Integer.parseInt(emulatorEndpoint.get().substring(split + 1));
299299
dataBuilder = BigtableDataSettings.newBuilderForEmulator(host, port);
300300
} else {
301+
String endpoint =
302+
BigtableDataSettings.newBuilder()
303+
.setProjectId(getProjectId())
304+
.setInstanceId(getInstanceId())
305+
.build()
306+
.getStubSettings()
307+
.getEndpoint();
308+
301309
dataBuilder = BigtableDataSettings.newBuilder();
302-
configureConnection(dataBuilder.stubSettings(), BIGTABLE_HOST_KEY);
310+
configureConnection(dataBuilder.stubSettings(), BIGTABLE_HOST_KEY, endpoint);
303311
configureCredentialProvider(dataBuilder.stubSettings());
304312
}
305313
configureHeaderProvider(dataBuilder.stubSettings());
@@ -366,8 +374,15 @@ private BigtableTableAdminSettings buildBigtableTableAdminSettings() throws IOEx
366374
int port = Integer.parseInt(emulatorEndpoint.substring(split + 1));
367375
adminBuilder = BigtableTableAdminSettings.newBuilderForEmulator(host, port);
368376
} else {
377+
String defaultEndpoint =
378+
BigtableTableAdminSettings.newBuilder()
379+
.setProjectId(getProjectId())
380+
.setInstanceId(getInstanceId())
381+
.build()
382+
.getStubSettings()
383+
.getEndpoint();
369384
adminBuilder = BigtableTableAdminSettings.newBuilder();
370-
configureConnection(adminBuilder.stubSettings(), BIGTABLE_ADMIN_HOST_KEY);
385+
configureConnection(adminBuilder.stubSettings(), BIGTABLE_ADMIN_HOST_KEY, defaultEndpoint);
371386
configureCredentialProvider(adminBuilder.stubSettings());
372387
}
373388
configureHeaderProvider(adminBuilder.stubSettings());
@@ -414,8 +429,14 @@ public ManagedChannelBuilder apply(
414429
})
415430
.build());
416431
} else {
432+
String defaultEndpoint =
433+
BigtableInstanceAdminSettings.newBuilder()
434+
.setProjectId(getProjectId())
435+
.build()
436+
.getStubSettings()
437+
.getEndpoint();
417438
adminBuilder = BigtableInstanceAdminSettings.newBuilder();
418-
configureConnection(adminBuilder.stubSettings(), BIGTABLE_ADMIN_HOST_KEY);
439+
configureConnection(adminBuilder.stubSettings(), BIGTABLE_ADMIN_HOST_KEY, defaultEndpoint);
419440
configureCredentialProvider(adminBuilder.stubSettings());
420441
}
421442
configureHeaderProvider(adminBuilder.stubSettings());
@@ -425,8 +446,8 @@ public ManagedChannelBuilder apply(
425446
return adminBuilder.build();
426447
}
427448

428-
private void configureConnection(StubSettings.Builder<?, ?> stubSettings, String endpointKey) {
429-
String defaultEndpoint = stubSettings.getEndpoint();
449+
private void configureConnection(
450+
StubSettings.Builder<?, ?> stubSettings, String endpointKey, String defaultEndpoint) {
430451
String defaultHostname = defaultEndpoint.substring(0, defaultEndpoint.lastIndexOf(':'));
431452
String defaultPort = defaultEndpoint.substring(defaultEndpoint.lastIndexOf(':') + 1);
432453

bigtable-client-core-parent/bigtable-hbase/src/test/java/com/google/cloud/bigtable/hbase/wrappers/veneer/TestBulkMutationVeneerApi.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import com.google.cloud.bigtable.data.v2.models.RowMutationEntry;
4242
import com.google.cloud.bigtable.hbase.wrappers.BulkMutationWrapper;
4343
import java.io.IOException;
44+
import java.util.concurrent.Executors;
4445
import java.util.concurrent.ScheduledExecutorService;
4546
import org.junit.Before;
4647
import org.junit.Rule;
@@ -124,12 +125,13 @@ public Object answer(InvocationOnMock invocationOnMock) {
124125

125126
@Test
126127
public void testWhenBatcherIsClosed() throws IOException {
127-
BatchingSettings batchingSettings = mock(BatchingSettings.class);
128-
FlowControlSettings flowControlSettings =
129-
FlowControlSettings.newBuilder()
130-
.setLimitExceededBehavior(LimitExceededBehavior.Ignore)
128+
BatchingSettings batchingSettings =
129+
BatchingSettings.newBuilder()
130+
.setFlowControlSettings(
131+
FlowControlSettings.newBuilder()
132+
.setLimitExceededBehavior(LimitExceededBehavior.Ignore)
133+
.build())
131134
.build();
132-
when(batchingSettings.getFlowControlSettings()).thenReturn(flowControlSettings);
133135

134136
BatchingDescriptor mockBatchingDescriptor = mock(BatchingDescriptor.class);
135137

@@ -141,16 +143,15 @@ public void testWhenBatcherIsClosed() throws IOException {
141143
when(unaryCallable.futureCall(any(), any()))
142144
.thenReturn(ApiFutures.immediateFuture(new Object()));
143145

146+
ScheduledExecutorService executor = Executors.newScheduledThreadPool(0);
147+
144148
@SuppressWarnings("unchecked")
145149
Batcher<RowMutationEntry, Void> actualBatcher =
146150
new BatcherImpl(
147-
mockBatchingDescriptor,
148-
unaryCallable,
149-
new Object(),
150-
batchingSettings,
151-
mock(ScheduledExecutorService.class));
151+
mockBatchingDescriptor, unaryCallable, new Object(), batchingSettings, executor);
152152
BulkMutationWrapper underTest = new BulkMutationVeneerApi(actualBatcher, 0);
153153
underTest.close();
154+
executor.shutdownNow();
154155

155156
Exception actualEx = null;
156157
try {

bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,7 @@ limitations under the License.
395395
<ignoredDependencies>
396396
<dependency>io.opentelemetry:opentelemetry-api</dependency>
397397
<dependency>io.opentelemetry:opentelemetry-context</dependency>
398+
<dependency>io.opentelemetry:opentelemetry-semconv</dependency>
398399
</ignoredDependencies>
399400
</configuration>
400401
</execution>

bigtable-hbase-2.x-parent/bigtable-hbase-2.x/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ limitations under the License.
184184
<ignoredDependencies>
185185
<dependency>io.opentelemetry:opentelemetry-api</dependency>
186186
<dependency>io.opentelemetry:opentelemetry-context</dependency>
187+
<dependency>io.opentelemetry:opentelemetry-semconv</dependency>
187188
</ignoredDependencies>
188189
</configuration>
189190
</execution>

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ limitations under the License.
3232
<parent>
3333
<groupId>com.google.cloud</groupId>
3434
<artifactId>google-cloud-shared-config</artifactId>
35-
<version>1.7.7</version>
35+
<version>1.11.1</version>
3636
</parent>
3737

3838
<licenses>
@@ -55,7 +55,7 @@ limitations under the License.
5555
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
5656

5757
<!-- core dependency versions -->
58-
<bigtable.version>2.39.2</bigtable.version>
58+
<bigtable.version>2.44.1</bigtable.version>
5959
<google-cloud-bigtable-emulator.version>0.175.0</google-cloud-bigtable-emulator.version>
6060
<bigtable-metrics-api.version>1.29.2</bigtable-metrics-api.version>
6161
<!-- Optional dep for bigtable-metrics-api used for tests -->

0 commit comments

Comments
 (0)