fix: fix timestamp rounding issue #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
stephaniewang526
force-pushed
the
timestamp
branch
from
c92a91b
to
2ecbcc3
Compare
tswast
changed the title
Fixes googleapis#1644 remove unrelated test case update test case
stephaniewang526
force-pushed
the
timestamp
branch
from
1c4b876
to
53ead88
Compare
tswast
requested changes
Oct 8, 2021
There was a problem hiding this comment.
This isn't a complete fix. We should really be setting the formatOptions.useInt64Timestamp request parameters to avoid any need for rounding at all:
Otherwise, BigQuery has an internal conversion to floating point, which likely can cause issues even with rounding.
Since Java allows exposing the raw string value, technically setting this would be a breaking change, so I'm okay with the current fix, but we should leave the issue open and consider taking a breaking change to fully address this.
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValue.java
Show resolved
Hide resolved
stephaniewang526
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
approved these changes
Oct 8, 2021
tswast
approved these changes
Oct 8, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://www.github.com/googleapis/java-bigquery/compare/v2.2.1...v2.3.0) (2021-10-15) ### Features * add session support ([#1652](https://www.github.com/googleapis/java-bigquery/issues/1652)) ([acc6cb8](https://www.github.com/googleapis/java-bigquery/commit/acc6cb8ad318ae41a9a3a00a5942025c14cbe681)) ### Bug Fixes * fix timestamp rounding issue ([#1645](https://www.github.com/googleapis/java-bigquery/issues/1645)) ([e60bdff](https://www.github.com/googleapis/java-bigquery/commit/e60bdff9e196a618a59a0544ec93f87b2ec5fc82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1644
Temp fix timestamp rounding error (to microsecond) which can be reproduced by setting query priority to
INTERACTIVE.