Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request timeout #45

Closed
farin opened this issue Nov 23, 2017 · 2 comments · Fixed by #116
Closed

Add request timeout #45

farin opened this issue Nov 23, 2017 · 2 comments · Fixed by #116
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@farin
Copy link

farin commented Nov 23, 2017

Hi
it seems that our project, which use https://github.com/GoogleCloudPlatform/google-cloud-python/tree/master/storage/google/cloud/storage, is getting stuck during upload.

Although we can't confirm it with absolute certainty, it may be good idea have request timeout in resumable-media anyway.
Questions are:

  • do you find a timeout good idea in general?
  • should be there some well-chosen conservative implicit timeout by library (or explicit user defined timeout is preferred despite much complicated implementation because this library is only used by other google cloud platform libraries)?

We can provide eg. pull request for default timeout but we rather discuss all first.

@lukesneeringer
Copy link
Contributor

I think a sane timeout makes sense.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Dec 8, 2018
@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 16, 2019
@tseaver tseaver changed the title Missing request timeout Add request timeout Jan 16, 2019
@tseaver
Copy link
Contributor

tseaver commented Jan 16, 2019

See also #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
6 participants