cleanup(gax): idiomatic return type for PollingErrorPolicy::on_in_progress()

[chrischiedo]

Resolves the remaining half of #2335.

The other half was fixed in #2456 (RetryPolicy::on_throttle())

cc: @dbolduc

[dbolduc]

/gcbrun

[dbolduc]

Thanks. Code in this file looks good. We also need corresponding changes in google-cloud-lro (which will hopefully simplify that code)

[chrischiedo]

which will hopefully simplify that code

Not sure that the change makes the code any simpler, but I think it's more idiomatic.

[dbolduc]

Not sure that the change makes the code any simpler, but I think it's more idiomatic.

You're right. I should have actually read the lro code before making such a statement. 😀

[dbolduc]

/gcbrun

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (9721263) to head (7deeb7c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2522   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files          79       79           
  Lines        3188     3188           
=======================================
  Hits         3045     3045           
  Misses        143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dbolduc]

Awesome, thanks!