Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'dataset.Dataset' -> 'client.Client'. #946

Merged
merged 1 commit into from
Jun 25, 2015
Merged

Rename 'dataset.Dataset' -> 'client.Client'. #946

merged 1 commit into from
Jun 25, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 23, 2015

See #944.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2015
@tseaver tseaver mentioned this pull request Jun 23, 2015
Closed
8 tasks
@dhermes
Copy link
Contributor

dhermes commented Jun 23, 2015

LGTM with emphasis on m == ME

@jgeewax May have a preference here.

@jgeewax
Copy link
Contributor

jgeewax commented Jun 25, 2015

OK so sample code would read something like...

client = datastore.Client(dataset_id='whatever')
client.get(<key here>)

?

If so, then huge +1.

@dhermes
Copy link
Contributor

dhermes commented Jun 25, 2015

@jgeewax Yes

@tseaver Feel free to merge. Do you have most of #944 waiting to be sent out or still working on it?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 25, 2015

It is still in work (I have the ordering / break-up somewhat wrong in #944).

tseaver added a commit that referenced this pull request Jun 25, 2015
@tseaver
Merge pull request #946 from tseaver/944-datastore_client_from_dataset
119cba3 
Rename 'dataset.Dataset' -> 'client.Client'.
@tseaver tseaver merged commit 119cba3 into googleapis:master Jun 25, 2015
@tseaver tseaver deleted the 944-datastore_client_from_dataset branch June 25, 2015 17:33
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Jun 25, 2015
@dhermes
Fixing location and name of dataset doc.
a5a3d57 
See googleapis#946 for context.
@dhermes dhermes mentioned this pull request Jun 25, 2015
Merged
@dhermes dhermes mentioned this pull request Jul 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @jgeewax @googlebot