BigQuery: Fix deserializing None QueryParameters #9029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For None parameters, the back-end does not return the parameter value in response. This commit adjusts the ScalarQueryParameter's method from_api_repr().
googlebot
added
the
cla: yes
tseaver
approved these changes
Aug 14, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
For None parameters, the back-end does not return the parameter value in response. This commit adjusts the ScalarQueryParameter's method from_api_repr().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9027.
For
Noneparameters, the back-end does not return the parameter value in response, causing an error when deserializing ScalarQueryParameter from JSON.How to test
Run the example from the issue description. With the fix applied, the error should not occur anymore, and the resulting
query_parametersobject is correct.