Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting Bucket.make_public(recursive=True). #878

Merged
merged 1 commit into from
May 14, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented May 13, 2015

Applying the same limit for number of blobs to iterate through
that Bucket.delete(force=True) has.

Applying the same limit for number of blobs to iterate through
that Bucket.delete(force=True) has.
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label May 13, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2015
@tseaver
Copy link
Contributor

tseaver commented May 14, 2015

LGTM.

BTW, what happened to coveralls.io?

dhermes added a commit that referenced this pull request May 14, 2015
Limiting Bucket.make_public(recursive=True).
@dhermes dhermes merged commit cf38c8d into googleapis:master May 14, 2015
@dhermes
Copy link
Contributor Author

dhermes commented May 14, 2015

Good catch on coveralls.

The output in Travis says:

You have to provide either repo_token in .coveralls.yml, or launch via Travis

This means we need to pass through the TRAVIS* environment variables to tox -e coveralls. I'll send a PR ASAP.

@dhermes dhermes deleted the limit-make-public branch May 14, 2015 18:12
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request May 14, 2015
@tmatsuo
Copy link
Contributor

tmatsuo commented May 14, 2015

Thanks guys, you save my day.

I encountered the same issue with coveralls.
tox 2.0 suddenly started to filter envvar.

@dhermes
Copy link
Contributor Author

dhermes commented May 14, 2015

w00t

It (tox 2.0) affected us (#875) and oauth2client (googleapis/oauth2client#176).

dhermes added a commit to dhermes/oauth2client that referenced this pull request May 14, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request May 14, 2015
Caused by googleapis#878 and googleapis#879 passing by each other simultaneously.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants