#818: unify RFC 3339 timestamp format strubg #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Use it consistently in pubsub.
|
Rebased after merge of #816 to master. |
|
Changes Unknown when pulling 5d13cbe on tseaver:818-unify_rfc_3339_format into * on GoogleCloudPlatform:master*. |
|
LGTM. Thanks for doing this! |
|
Actually wait, don't we want to put a timezone on the stamps in storage? |
| @@ -749,7 +749,7 @@ def time_deleted(self): | |||
| """ | |||
| value = self._properties.get('timeDeleted') | |||
| if value is not None: | |||
| return datetime.datetime.strptime(value, _GOOGLE_TIMESTAMP_FORMAT) | |||
| return datetime.datetime.strptime(value, _RFC3339_MICROS) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This PR fixes the |
|
Everything LGTM if it LGTY |
tseaver
added a commit
that referenced
this pull request
Apr 16, 2015
#818: unify RFC 3339 timestamp format strubg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use consistently across
storageandpubsub.Fixes #818.
Uses #816 as a diffbase.