Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reader.ReadRowsPage to use _StreamParser. #8262

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jun 6, 2019

This will enable us to use alternative libraries and wire formats.
Previously, ReadRowsPage was closely coupled to the fastavro library.

Towards #7805 since we'll want an alternative parser and/or wire format in the future to improve performance.

This will enable us to use alternative libraries and wire formats.
Previously, ReadRowsPage was closely coupled to the fastavro library.
@tswast tswast requested a review from a team June 6, 2019 21:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2019
@tswast tswast requested a review from shollyman June 6, 2019 21:29
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does "block" sufficiently describe the same set-of-rows avro concept in other formats like arrow, or should we call it something like binary page?

@tswast
Copy link
Contributor Author

tswast commented Jun 6, 2019

Arrow calls the concept "batch".

In this module, whereever I refer to "block" is really a whole ReadRowsResponse message. I've just pushed a commit that renamed it to "message" to match the GRPC terminology.

@tswast tswast changed the title Refactor reader.ReadRowsPage to use _BlockParser. Refactor reader.ReadRowsPage to use _StreamParser. Jun 6, 2019
@tswast tswast merged commit 42ffb49 into googleapis:master Jun 6, 2019
@tswast tswast deleted the bqstorage-fastavro-schema branch June 6, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants