-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin pubsub regression suite #765
Begin pubsub regression suite #765
Conversation
Got a lot of unused variables (I assume build failed). Also the do nothing setup and Other questions
(Sorry for hacky review. On phone.) |
I rebased to remove #764 and adjust the tests to accommodate the changed URIs. Per the API docs, the URIs are all based at https://pubsub.googleapis.com/v1beta2, rather than https://www.googleapis.com/pubsub/v1beta1. I know they are right because the regression tests were all 404ing with non-JSON errors before. :) |
I plan to add more tests in later PRs (e.g., once we decide about returning |
Still have unused vars Just call me the human linter :) Other than LGTM (if you don't don't can you squash these fixed into the original commit, 4 commits for tint change is sadness) |
@dhermes I removed those variables and the import, and squashed it down to two commits. |
Looks great thanks |
Uses #764 as a base.