Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate JSON services which do not return JSON payloads for errors. #764

Closed
wants to merge 1 commit into from
Closed

Accomodate JSON services which do not return JSON payloads for errors. #764

wants to merge 1 commit into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 27, 2015

I'm lookin' at you, pubsub.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2015
@dhermes
Copy link
Contributor

dhermes commented Mar 27, 2015

WAT? @tmatsuo Can we file a formal bug about not using JSON errors from a discovery-based API?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 25f92d2 on tseaver:json_api-non_json_errors into d34a15e on GoogleCloudPlatform:master.

@tmatsuo
Copy link
Contributor

tmatsuo commented Mar 27, 2015

This is presumably because Pub/Sub is on the newer infrastructure.

I assume other APIs return JSON errors. Is that behavior defined somewhere? or are you just expecting the same behavior as other APIs?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 27, 2015

@dhermes
Copy link
Contributor

dhermes commented Mar 27, 2015

@tseaver this LGTM but can you capture the raw content in an api_request and post it, just so I can see?

@dhermes
Copy link
Contributor

dhermes commented Mar 27, 2015

@tmatsuo JSON half the time is crazy, no matter the infrastructure. Please send my feedback into the black hole of feedback.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 27, 2015

Hmm, I was working with a bad API_BASE_URL earlier, which means the No Content was not generated by the pubsub API. It actually returns:

{
  "error": {
    "code": 404,
    "message": "Resource not found (resource=a-new-topic).",
    "status": "NOT_FOUND"
  }
}

@tseaver tseaver closed this Mar 27, 2015
@dhermes
Copy link
Contributor

dhermes commented Mar 27, 2015

Yay!

@dhermes
Copy link
Contributor

dhermes commented Mar 27, 2015

@tmatsuo My feedback turns out to be irrelevant! w00t!

@tmatsuo
Copy link
Contributor

tmatsuo commented Mar 27, 2015

Good to know!

@tseaver tseaver deleted the json_api-non_json_errors branch May 1, 2015 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants