-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accomodate JSON services which do not return JSON payloads for errors. #764
Conversation
I'm lookin' at you, pubsub.
WAT? @tmatsuo Can we file a formal bug about not using JSON errors from a discovery-based API? |
This is presumably because Pub/Sub is on the newer infrastructure. I assume other APIs return JSON errors. Is that behavior defined somewhere? or are you just expecting the same behavior as other APIs? |
@tmatsuo storage returns JSON: https://cloud.google.com/storage/docs/json_api/v1/status-codes#errorformat |
@tseaver this LGTM but can you capture the raw |
@tmatsuo JSON half the time is crazy, no matter the infrastructure. Please send my feedback into the black hole of feedback. |
Hmm, I was working with a bad
|
Yay! |
@tmatsuo My feedback turns out to be irrelevant! w00t! |
Good to know! |
I'm lookin' at you, pubsub.