Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 20, 2015

Second bullet for #741.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. api: core labels Mar 20, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2015
@tseaver tseaver changed the title Hoist project detection/setup into 'gcloud._helpers'. #741: hoist project detection/setup into 'gcloud._helpers'. Mar 20, 2015

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Mar 20, 2015

So everything looks good but I want to resolve this discussion. Also still waiting on Travis.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c590c56 on tseaver:741-hoist_default_project into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 23, 2015

Per today's standup, @jgeewax believes that having the same default project across storage and pubsub (and maybe other APIs) is fine. Users who need to vary from the default just pass it explicitly.

tseaver added a commit that referenced this pull request Mar 23, 2015
#741: hoist project detection/setup into 'gcloud._helpers'.
@tseaver tseaver merged commit 4512eff into googleapis:master Mar 23, 2015
@dhermes
Copy link
Contributor

dhermes commented Mar 23, 2015

@tseaver Can you rebase #749? I'm about to step out and want to finish the review.

@tseaver tseaver deleted the 741-hoist_default_project branch March 23, 2015 19:22
parthea pushed a commit that referenced this pull request Nov 22, 2025
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* fix: fix fetch_id_token credential lookup order to match adc

* fix tests

* fix linter

* update

* update

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants