Swapping the order of kind and dataset_id in Query constructor. #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
change-query-argument-order
branch
from
e7b3e23 to
5fd4656
Compare
gcloud/datastore/query.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM, modulo the |
Also updating docstring in Query.fetch() to reflect this. Partially addresses googleapis#704.
dhermes
force-pushed
the
change-query-argument-order
branch
from
5fd4656 to
749712e
Compare
Contributor
Author
|
Rebased on top of HEAD / swapped the docstring args back to the rightful position. Will wait on Travis before merging. Boo to slow Travis. It seems they went from no outages to weekly outages in the recent past. |
|
Changes Unknown when pulling 749712e on dhermes:change-query-argument-order into * on GoogleCloudPlatform:master*. |
|
Changes Unknown when pulling 749712e on dhermes:change-query-argument-order into * on GoogleCloudPlatform:master*. |
Contributor
Author
|
Merging. Coveralls decided not to send the message but it says 100%: UPDATE: Coveralls literally sent the go-ahead as I clicked "Comment". Amazing! |
dhermes
added a commit
that referenced
this pull request
Mar 12, 2015
Swapping the order of kind and dataset_id in Query constructor.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
parthea
added a commit
that referenced
this pull request
Nov 22, 2025
* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * require proto-plus 1.22.2 for python 3.11 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
… index (#718) * feat: add ApiScope and COLLECTION_RECURSIVE query_scope for Firestore index PiperOrigin-RevId: 532955594 Source-Link: googleapis/googleapis@b4bb0e2 Source-Link: googleapis/googleapis-gen@57104e2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTcxMDRlMmEwOGI3N2Q3YzVmMzllYjViOTcyY2U5ODFkNzgyMjQ0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: meredithslota <meredithslota@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updating docstring in Query.fetch() to reflect this.
Partially addresses #704.