#652: Harden ACL 'save'/'reload' against missing element in server response. #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, the back-end can (in some cases, at least) omit empty 'acl' elements from the returned resource. Fixes #652.
googlebot
added
the
cla: yes
Contributor
|
LGTM. I was kind of unclear in the discussion in #652 about whether this should be happening / other places we can deal with it. |
Contributor
Author
|
Having FWIW, I don't understand why the back-end would "optimize away" the empty |
tseaver
added a commit
that referenced
this pull request
Feb 26, 2015
#652: Harden ACL 'save'/'reload' against missing element in server response.
parthea
added a commit
that referenced
this pull request
Nov 22, 2025
* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Adds nox and CI targets for 3.9
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* build: use mypy<1.11.0 until #682 is fixed * add comment
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the back-end can (in some cases, at least) omit empty 'acl'
elements from the returned resource.
Fixes #652.