Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Black. Template noxfile + flake8. #6642

Merged
merged 26 commits into from
Nov 28, 2018
Merged

Add Black. Template noxfile + flake8. #6642

merged 26 commits into from
Nov 28, 2018

Conversation

crwilcox
Copy link
Contributor

  • Add Templating support to existing synth.py
  • Refactor Synth scripts to have similar style
  • Add black target and coverage to all synth.py

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2018
@tswast
Copy link
Contributor

tswast commented Nov 26, 2018

Cool! A bit difficult to review, though. Which files are the hand-edited ones?

@crwilcox
Copy link
Contributor Author

:) I tried to make it not too bad. the hand edited files are synth.py. There is some other hand-editing to mirror generation.
At a high-level

  • get templates from synth now (noxfile, coveragerc, flake8)
  • for each library tweak coverage numbers to match what is seen. This is still in progress but the only things that will change is the int for coverage.

@crwilcox
Copy link
Contributor Author

I should also note, some lint may fail right now. I am waiting until people have reviewed this to actually blacken (to avoid random noise in review)

tswast
tswast reviewed Nov 26, 2018
View reviewed changes
asset/synth.py Outdated
# ----------------------------------------------------------------------------
# Add templated files
# ----------------------------------------------------------------------------
templated_files = gcp.CommonTemplates().py_library(unit_cov_level=86, cov_level=85)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/.coveragerc
@@ -11,3 +11,6 @@ exclude_lines =
def __repr__
# Ignore abstract methods
raise NotImplementedError
omit =
*/gapic/*.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

asset/.flake8
@@ -1,4 +1,5 @@
[flake8]
ignore = E203, E266, E501, W503

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2018
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2018
@crwilcox crwilcox deleted the templating branch November 28, 2018 21:55
@dhermes dhermes mentioned this pull request Nov 29, 2018
Merged
erikwebb pushed a commit to erikwebb/google-cloud-python that referenced this pull request Dec 3, 2018
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (googleapis…
c6c57b9 
…#6642)
chrisrossi pushed a commit to chrisrossi/google-cloud-python that referenced this pull request Feb 22, 2019
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (googleapis…
9560095 
…#6642)
This was referenced Aug 18, 2021
Merged
Closed
atulep pushed a commit that referenced this pull request Apr 3, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
498e128
atulep pushed a commit that referenced this pull request Apr 18, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
e90e0a7
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
3c48d1c
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
235a7cc
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
c336696
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
6d16b71
parthea pushed a commit that referenced this pull request Jul 6, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
ce66b22
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
28cee5a
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
56cd632
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
4103c45
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
d327dfe
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
bc57f48
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
656b72b
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
f3c613a
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
9276842
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
4e4ecf8
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
0d23d54
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
a174346
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
1326851
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
e169d5d
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
15cf2f2
parthea pushed a commit that referenced this pull request Oct 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
656a6a7
parthea pushed a commit that referenced this pull request Oct 22, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
128b577
parthea pushed a commit that referenced this pull request Oct 31, 2023
@crwilcox
Add templates for flake8, coveragerc, noxfile, and black. (#6642)
ac7b4dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

@theacodes theacodes theacodes approved these changes

@alixhami alixhami Awaiting requested review from alixhami

@dhermes dhermes Awaiting requested review from dhermes

@tseaver tseaver Awaiting requested review from tseaver

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crwilcox @tswast @theacodes @googlebot @kokoro-team @yoshi-kokoro