Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load defaults #657

Closed
wants to merge 4 commits into from
Closed

Lazy load defaults #657

wants to merge 4 commits into from

Commits on Feb 17, 2015

  1. Using DEFAULT_ENVIRON instance instead of _implicit_environ module. 

    Currently failing lint due to using constants (all caps) as attributes
that can change.
    @dhermes
    dhermes committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    efb48be View commit details
    Browse the repository at this point in the history

  2. Using lowercase property names in datastore Environment. 

    CONNECTION->connection
DATASET_ID->dataset_id
    @dhermes
    dhermes committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    f067b1b View commit details
    Browse the repository at this point in the history

  3. Moving set_default_dataset_id to _implicit_environ module. 

    Also splitting out behavior into a get_default_dataset_id method
and then the set_default_dataset_id around in.
    @dhermes
    dhermes committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    83e3d9f View commit details
    Browse the repository at this point in the history

  4. Adding lazy loading property for dataset ID in Environment.

    @dhermes
    dhermes committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    662ad4a View commit details
    Browse the repository at this point in the history