Allow string in addition to DatasetReference / TableReference in Clie… #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt methods. Whereever a client method accepts a DatasetReference or TableReference, it now also accepts a string. The project ID can be omitted from the string and the Client's default project is used instead. Also, to make it easier to share code across client methods for creating XReference classes: * Add default_project argument to DatasetReference.from_string * Add default_project argument to TableReference.from_string
googlebot
added
the
cla: yes
max-sixty
reviewed
Oct 4, 2018
|
|
||
| if isinstance(destination, str): | ||
| destination = TableReference.from_string( | ||
| destination, default_project=self.project) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thank you @tseaver ! I find this far more pythonic and easier to use (e.g. the proportion of instances I'll use the API without pulling up the docs is much higher). Interested what others think. |
tswast
commented
Oct 4, 2018
| :type retry: :class:`google.api_core.retry.Retry` | ||
| :param retry: (Optional) How to retry the RPC. | ||
| Args: | ||
| dataset_ref (Union[ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dpebot merge when green |
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
dpebot
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt methods.
Whereever a client method accepts a DatasetReference or TableReference,
it now also accepts a string. The project ID can be omitted from the
string and the Client's default project is used instead.
Also, to make it easier to share code across client methods for creating
XReference classes:
Towards #6055. Not closes because we should add similar logic to the
create_datasetandcreate_tablemethods, but they need to be modified to also accept a reference. My thought there is that we can create an empty table/dataset resource when a string or reference is passed in.@max-sixty Please take a look.