Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bogus examples of 'database.transaction()'. #6032

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Remove bogus examples of 'database.transaction()'. #6032

merged 2 commits into from
Sep 20, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 19, 2018

/cc @snehashah16

Use session.transaction() instead.

Use ReST markup to set off notes about manual transaction usage.

Closes #6029.

Use 'session.transaction()' instead.

Use ReST markup to set off notes about manual transaction usage.

Closes #6029.
@tseaver tseaver added documentation api: spanner Issues related to the Spanner API. labels Sep 19, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2018
Copy link

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Normally, applications will not construct transactions manually. Rather,
consider using :meth:`~Database.run_in_transaction` or the context manager
s described above.

This comment was marked as spam.

[ci skip]
@tseaver tseaver merged commit 539d4b9 into googleapis:master Sep 20, 2018
@tseaver tseaver deleted the 6029-spanner-dont_document-database.transaction branch September 20, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants