Connection lookup single request #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
connection-lookup-single-request
branch
from
3b118d2 to
fd833ce
Compare
|
|
||
| return results | ||
| return results, missing, lookup_response.deferred |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
connection-lookup-single-request
branch
from
fd833ce to
c956b3a
Compare
dhermes
force-pushed
the
connection-lookup-single-request
branch
from
c956b3a to
d517a75
Compare
|
LGTM |
This was so that Connection.lookup was only performing the API call by the same name. The "lookup until all deferred return" behavior has been moving into `datastore.get` (which is where end users expect the behavior).
dhermes
force-pushed
the
connection-lookup-single-request
branch
from
d517a75 to
e9c6260
Compare
|
Changes Unknown when pulling e9c6260 on dhermes:connection-lookup-single-request into * on GoogleCloudPlatform:master*. |
dhermes
added a commit
that referenced
this pull request
Feb 3, 2015
Connection lookup single request
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #582 as a diffbase.
@tseaver This is based on my comment in the other PR. If you disagree, we can torpedo this PR. (FWIW I don't see a reason why we'd want this behavior on the
Connectionrather than associated withdatastore.get, but maybe I'm missing something.)