BQ: rename XJob.name to XJob.job_id. #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
System tests running at https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3265 |
jba
approved these changes
Sep 15, 2017
|
Let me know if you need/want an assist on that system test failure. |
|
I think some of the failures are a few system tests got missed in #3959. I pushed a fix. |
|
System tests will be available at https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3296 |
|
I still can't get the logs to load for the system tests, but they pass locally. Merging. |
tswast
added a commit
that referenced
this pull request
Sep 25, 2017
* BQ: rename XJob.name to XJob.job_id. * BQ: Remove references to table.name
tswast
added a commit
that referenced
this pull request
Oct 12, 2017
* BQ: rename XJob.name to XJob.job_id. * BQ: Remove references to table.name
tswast
added a commit
that referenced
this pull request
Oct 16, 2017
* BQ: rename XJob.name to XJob.job_id. * BQ: Remove references to table.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go with all our other renames.