Allow fetching more than the first page when max_results is set. #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Oh, also fixes a bug where |
lukesneeringer
approved these changes
Aug 19, 2017
Add a system test to call `fetchall()` when multiple rows are expected.
This error applies to all BigQuery iterators, not just DB-API.
It was allowed before, but it didn't result in the correct behavior.
In BigQuery it means the page size, but the HTTPIterator it meant "don't fetch any more pages once you have these many rows."
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
…gleapis#3845) * BigQuery: reproduce error fetching multiple results with DB-API. Add a system test to call `fetchall()` when multiple rows are expected. * BigQuery: system test to reproduce error of only fetching first page. This error applies to all BigQuery iterators, not just DB-API. * BigQuery: allow arraysize to be set after execute() It was allowed before, but it didn't result in the correct behavior. * max_results in BigQuery API had a different meaning from HTTPIterator. In BigQuery it means the page size, but the HTTPIterator it meant "don't fetch any more pages once you have these many rows." * Fix lint errors
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…gleapis#3845) * BigQuery: reproduce error fetching multiple results with DB-API. Add a system test to call `fetchall()` when multiple rows are expected. * BigQuery: system test to reproduce error of only fetching first page. This error applies to all BigQuery iterators, not just DB-API. * BigQuery: allow arraysize to be set after execute() It was allowed before, but it didn't result in the correct behavior. * max_results in BigQuery API had a different meaning from HTTPIterator. In BigQuery it means the page size, but the HTTPIterator it meant "don't fetch any more pages once you have these many rows." * Fix lint errors
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…gleapis#3845) * BigQuery: reproduce error fetching multiple results with DB-API. Add a system test to call `fetchall()` when multiple rows are expected. * BigQuery: system test to reproduce error of only fetching first page. This error applies to all BigQuery iterators, not just DB-API. * BigQuery: allow arraysize to be set after execute() It was allowed before, but it didn't result in the correct behavior. * max_results in BigQuery API had a different meaning from HTTPIterator. In BigQuery it means the page size, but the HTTPIterator it meant "don't fetch any more pages once you have these many rows." * Fix lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3840