Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google.api.page_iterator.GRPCIterator #3843

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How dare you keep sending such short and well-crafted PRs!


if self.next_page_token is not None:
setattr(
self._request, self._request_token_field, self.next_page_token)

This comment was marked as spam.

This comment was marked as spam.

items = getattr(response, self._items_field)
page = Page(self, items, self._item_to_value)

return page

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor Author

How dare you keep sending such short and well-crafted PRs!

Let's see how long I can keep this streak up. :)

@theacodes theacodes merged commit 406ecad into googleapis:master Aug 18, 2017
@theacodes theacodes deleted the grpc-iterator branch August 18, 2017 20:40
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants