Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename class: 'dataset.AccessGrant' -> 'dataset.AccessEntry'. #3798

Merged
merged 5 commits into from
Aug 18, 2017
Merged

Rename class: 'dataset.AccessGrant' -> 'dataset.AccessEntry'. #3798

merged 5 commits into from
Aug 18, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 12, 2017

Uses #3797 as a base.

@tseaver tseaver requested review from tswast and dhermes August 12, 2017 18:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2017
@tseaver tseaver mentioned this pull request Aug 12, 2017
18 tasks
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes.

@tswast tswast merged commit 72e0976 into googleapis:bigquery-b2 Aug 18, 2017
@tseaver tseaver deleted the bigquery-b2-rename_acl_entry branch September 8, 2017 12:56
tseaver added a commit that referenced this pull request Sep 8, 2017
tseaver added a commit that referenced this pull request Sep 11, 2017
* Rename class: 'dataset.AccessGrant' -> 'dataset.AccessEntry'.

* PEP8 names for unit test helpers.

* Rename 'Dataset.access_grants' -> 'Dataaset.access_entries'.
tseaver added a commit that referenced this pull request Sep 11, 2017
tswast pushed a commit that referenced this pull request Sep 25, 2017
* Rename class: 'dataset.AccessGrant' -> 'dataset.AccessEntry'.

* PEP8 names for unit test helpers.

* Rename 'Dataset.access_grants' -> 'Dataaset.access_entries'.
tswast pushed a commit that referenced this pull request Sep 25, 2017
tswast pushed a commit that referenced this pull request Oct 12, 2017
* Rename class: 'dataset.AccessGrant' -> 'dataset.AccessEntry'.

* PEP8 names for unit test helpers.

* Rename 'Dataset.access_grants' -> 'Dataaset.access_entries'.
tswast pushed a commit that referenced this pull request Oct 12, 2017
tswast pushed a commit that referenced this pull request Oct 16, 2017
* Rename class: 'dataset.AccessGrant' -> 'dataset.AccessEntry'.

* PEP8 names for unit test helpers.

* Rename 'Dataset.access_grants' -> 'Dataaset.access_entries'.
tswast pushed a commit that referenced this pull request Oct 16, 2017
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
…Platform/python-docs-samples#3798)

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants