Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase backoff to fix monitoring system test #3769

Merged
merged 4 commits into from
Aug 9, 2017

Conversation

liyanhui1228
Copy link
Contributor

Fixes #3739. The max waiting time will be 2 * (1+3+9+27+81) = 242 seconds.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
@lukesneeringer lukesneeringer merged commit 15ed5e7 into googleapis:master Aug 9, 2017
tseaver added a commit that referenced this pull request Aug 10, 2017
Because the context managers they use returned the session to the database's
pool, application code could not safely iterate over the result sets
returned by the methods.

Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize
iteration of their results sets before the session is returned to the
database pool (i.e., within the 'with' block which constructs the snapshot).

Closes #3769.
tseaver added a commit that referenced this pull request Aug 10, 2017
…3787)

Because the context managers they use returned the session to the database's
pool, application code could not safely iterate over the result sets
returned by the methods.

Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize
iteration of their results sets before the session is returned to the
database pool (i.e., within the 'with' block which constructs the snapshot).

Closes #3769.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
…oogleapis#3787)

Because the context managers they use returned the session to the database's
pool, application code could not safely iterate over the result sets
returned by the methods.

Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize
iteration of their results sets before the session is returned to the
database pool (i.e., within the 'with' block which constructs the snapshot).

Closes googleapis#3769.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
…oogleapis#3787)

Because the context managers they use returned the session to the database's
pool, application code could not safely iterate over the result sets
returned by the methods.

Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize
iteration of their results sets before the session is returned to the
database pool (i.e., within the 'with' block which constructs the snapshot).

Closes googleapis#3769.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
…oogleapis#3787)

Because the context managers they use returned the session to the database's
pool, application code could not safely iterate over the result sets
returned by the methods.

Update docs for 'Snapshot.read' and 'Snapshot.execute_sql' to emphasize
iteration of their results sets before the session is returned to the
database pool (i.e., within the 'with' block which constructs the snapshot).

Closes googleapis#3769.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants