Make 'QueryResponse.fetch_data' return an iterator. #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a system test which exercises it. Update snippets to match the new usage. Closes #2840.
tseaver
added
api: bigquery
googlebot
added
the
cla: yes
tswast
reviewed
Jun 15, 2017
| :type response: dict | ||
| :param response: The JSON API response for a page of rows in a table. | ||
| """ | ||
| iterator.query_result._set_properties(response) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
added a commit
that referenced
this pull request
Jul 5, 2017
tseaver
added a commit
that referenced
this pull request
Jul 10, 2017
|
The code sample on the documentation has been updated in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/bigquery/cloud-client/async_query.py I've sent a request to republish the cloud.google.com docs page. |
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
Add a system test which exercises it. Update snippets to match the new usage. Closes googleapis#2840.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Add a system test which exercises it. Update snippets to match the new usage. Closes googleapis#2840.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Add a system test which exercises it. Update snippets to match the new usage. Closes googleapis#2840.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a system test which exercises it.
Update snippets to match the new usage.
Closes #2840.