Making Subscription.reload() update the topic if unset. #3397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
approved these changes
May 15, 2017
dhermes
force-pushed
the
pubsub-topic-subs-reload
branch
2 times, most recently
from
f495808 to
a1c10ba
Compare
Also: removing Subscription._project and Snapshot._project since they are never used (and they shadow data that they shouldn't).
dhermes
force-pushed
the
pubsub-topic-subs-reload
branch
from
a1c10ba to
4835bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Subscription._projectandSnapshot._projectsince they are never used (and they shadow data that they shouldn't).