-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update speech usage examples. #3206
Update speech usage examples. #3206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not a great opportunity to other put this in a speech_snippets.py
file or follow the template of datastore
and just test as doctests?
docs/speech-usage.rst
Outdated
... speech.Encoding.FLAC, 16000, | ||
... source_uri='gs://my-bucket/recording.flac', language_code='en-GB', | ||
... max_alternatives=2) | ||
>>> results = sample.sync_recognize(language_code='en-GB', max_alternatives=2) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@dhermes yeah I think it would be. @lukesneeringer sounded like I should just run through these manually for now but I'm game either way. @lukesneeringer WDYT? |
These "hand-crafted" code snippets will always be vulernable to bit-rot if we don't have a way to test them. |
Speech is not a GA candidate, so if you are done checking off the GA requirements, feel free to take a more involved pass and make doctests. |
To be clear, though, please make sure everything is pristine on the GA libraries first. |
@lukesneeringer @dhermes continue back into the original issue? |
Yes. |
@lukesneeringer / @dhermes is this good to merge? |
Towards: #3172
Test script: https://gist.github.com/daspecster/718d01c7896ee576743292549cfb6927