Skip to content

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 31, 2014

Not meant to be merged. Some missing features were
uncovered or hard to use APIs and I want to discuss here
and then map out the plan (i.e. how to break this up).

@dhermes dhermes added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. testing labels Oct 31, 2014
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bdd28b6 on dhermes:storage-regression-tests into * on GoogleCloudPlatform:master*.

@dhermes dhermes force-pushed the storage-regression-tests branch from bdd28b6 to 7185cb8 Compare October 31, 2014 20:30
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7185cb8 on dhermes:storage-regression-tests into 8e12e10 on GoogleCloudPlatform:master.

@dhermes dhermes force-pushed the storage-regression-tests branch from 7185cb8 to 501bbe0 Compare October 31, 2014 23:18
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 501bbe0 on dhermes:storage-regression-tests into 26d7eef on GoogleCloudPlatform:master.

@dhermes dhermes force-pushed the storage-regression-tests branch from 501bbe0 to 4211f38 Compare November 1, 2014 08:25
@dhermes
Copy link
Contributor Author

dhermes commented Nov 1, 2014

@tseaver or @silvolu, any comments on this?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4211f38 on dhermes:storage-regression-tests into 632e126 on GoogleCloudPlatform:master.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes force-pushed the storage-regression-tests branch from 4211f38 to fb3b3ba Compare November 3, 2014 21:38
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fb3b3ba on dhermes:storage-regression-tests into f33e557 on GoogleCloudPlatform:master.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7f32773 on dhermes:storage-regression-tests into 2b73c7b on GoogleCloudPlatform:master.

@dhermes dhermes force-pushed the storage-regression-tests branch from 7f32773 to b48ce7a Compare November 4, 2014 18:18
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b48ce7a on dhermes:storage-regression-tests into abe3d7c on GoogleCloudPlatform:master.

@dhermes dhermes force-pushed the storage-regression-tests branch from b48ce7a to c9f948d Compare November 4, 2014 18:36
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c9f948d on dhermes:storage-regression-tests into a410c6a on GoogleCloudPlatform:master.

Note meant to be merged. Some missing features were
uncovered or hard to use APIs and I want to discuss here
and then map out the plan (i.e. how to break this up).
@dhermes dhermes force-pushed the storage-regression-tests branch from c9f948d to 16c5ad9 Compare November 4, 2014 22:29
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 16c5ad9 on dhermes:storage-regression-tests into 826ea69 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Nov 5, 2014

@tseaver This has been rebased on top of #332, PTAL.

I have yet to change the edit to Bucket.upload_file (where the Key is returned), but I can pursue the approach we discussed of constructing the key in the test.

@tseaver
Copy link
Contributor

tseaver commented Nov 5, 2014

Ugh, I've lost the thread now of what I meant. I'd say go ahead and land it, and we'll work it out later if it comes clear.

@dhermes dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2014
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
parthea added a commit that referenced this pull request Jun 4, 2023
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
- [ ] Regenerate this pull request now.

feat: AuditConfig for IAM v1
fix(deps): require grpc-google-iam-v1 >=0.12.4
docs: fix type in docstring for map fields

PiperOrigin-RevId: 440383959

Source-Link: googleapis/googleapis@6a276f6

Source-Link: googleapis/googleapis-gen@f94fc64
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjk0ZmM2NDA2MTgzNzAzM2JhYjg4YzY1MDc1ZTE4MTRlZGI2MTMzYSJ9
parthea pushed a commit that referenced this pull request Sep 20, 2023
- [ ] Regenerate this pull request now.

feat: release AttributesConfig APIs to v2 version
feat: release CompletionConfig APIs to v2 version
feat: add local inventories info to the Product resource
docs: Improved documentation for Fullfillment and Inventory API in ProductService
docs: minor documentation format and typo fixes

PiperOrigin-RevId: 469399525

Source-Link: googleapis/googleapis@e9bcb6c

Source-Link: googleapis/googleapis-gen@14169c6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTQxNjljNjQ1ZTY0MTc1YjQ0MWQ1OTljZGI1MDBjMTdmOTY0NDFiMiJ9
parthea pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
docs: added notes to train agent prior to sending queries 

fix: added resource reference to agent_version

PiperOrigin-RevId: 380595849

Source-Link: googleapis/googleapis@5fe3c63

Source-Link: googleapis/googleapis-gen@a2b223a

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea pushed a commit that referenced this pull request Sep 22, 2023
* feat: add a FastSocket API

PiperOrigin-RevId: 491381130

Source-Link: googleapis/googleapis@6485d9c

Source-Link: googleapis/googleapis-gen@36f17cc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzZmMTdjYzk0ZTA3NjIzYWEzODRjYmQ0MGQ2OTRjMTExZTk3ZTQxYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
* chore: fix markdown format

Committer: @medb
PiperOrigin-RevId: 420314583

Source-Link: googleapis/googleapis@94ea1c4

Source-Link: googleapis/googleapis-gen@e19b9f5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTE5YjlmNTRkMDFhODk0MTUyMjcxYjU0Mzc0ZmJhMDFkZDIyNGI2MCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
…p/templates/python_library/.kokoro (#319)

Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea pushed a commit that referenced this pull request Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea added a commit that referenced this pull request Oct 21, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jan 10, 2025
Source-Link: googleapis/synthtool@59171c8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants