Vision 1.1 API Client #3069

lukesneeringer · 2017-02-25T02:25:09Z

Final merge of the Vision 1.1 API client.
Needs CI to complete (and possibly the 0.15.2 GAPIC to propagate).

Fixes #233.

googlebot · 2017-02-25T02:25:11Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

docs/vision-usage.rst

@@ -317,6 +341,43 @@ Multiple images can be processed with a single request by passing
    <Likelihood.VERY_LIKELY: 'POSSIBLE'>


+***************
+Web Annotations


daspecster · 2017-02-25T03:02:24Z

/cc @jonparrott for samples.

tox.ini

@@ -270,6 +270,8 @@ commands =
    {[testing]localdeps}
    python {toxinidir}/system_tests/attempt_system_tests.py {posargs}
 deps =
+    {toxinidir}/_vendor/proto-google-cloud-vision-v1


daspecster · 2017-02-25T03:49:04Z

~~Fixing the lint issue.~~

daspecster · 2017-02-25T04:46:11Z

I'm not sure what's going on with Travis-pr. I cleared the caches for it I think. Once the Travis-push turns green I'll delete the other caches and try Travis-pr again.

daspecster · 2017-02-25T04:52:41Z

Deleted caches and restarted travis.

daspecster · 2017-02-25T05:08:25Z

@lukesneeringer I think you force pushed and removed my commits before.

lukesneeringer · 2017-02-25T05:36:35Z

Yeah, I did. Sorry, I thought I was plowing over one of mine.

lukesneeringer · 2017-02-25T05:43:49Z

I am waiting on the last Travis run to finally pass (even though it is running twice sequentially due to the way I pushed).

lukesneeringer · 2017-02-25T05:57:37Z

Finally done. (And docs even build!)

theacodes · 2017-02-27T17:07:19Z

@gguuss are you taking on samples for this?

gguuss · 2017-02-27T19:09:34Z

@jonparrott correct, the samples are ready.

lukesneeringer · 2017-02-27T22:32:08Z

Am I correct to assume this means docs are updated as well?

…3069)](GoogleCloudPlatform/python-docs-samples#3069) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-datacatalog](https://togithub.com/googleapis/python-datacatalog) | minor | `==0.5.0` -> `==0.6.0` | --- ### Release Notes <details> <summary>googleapis/python-datacatalog</summary> ### [`v0.6.0`](https://togithub.com/googleapis/python-datacatalog/blob/master/CHANGELOG.md#060httpswwwgithubcomgoogleapispython-datacatalogcomparev050v060-2020-02-24) [Compare Source](https://togithub.com/googleapis/python-datacatalog/compare/v0.5.0...v0.6.0) ##### Features - **datacatalog:** add sample for create a fileset entry quickstart ([#9977](https://www.github.com/googleapis/python-datacatalog/issues/9977)) ([16eaf4b](https://www.github.com/googleapis/python-datacatalog/commit/16eaf4b16cdc0ce7361afb1d8dac666cea2a9db0)) - **datacatalog:** undeprecate resource name helper methods, bump copyright year to 2020, tweak docstring formatting (via synth) ([#10228](https://www.github.com/googleapis/python-datacatalog/issues/10228)) ([84e5e7c](https://www.github.com/googleapis/python-datacatalog/commit/84e5e7c340fa189ce4cffca4fdee82cc7ded9f70)) - add `list_entry_groups`, `list_entries`, `update_entry_group` methods to v1beta1 (via synth) ([#6](https://www.github.com/googleapis/python-datacatalog/issues/6)) ([b51902e](https://www.github.com/googleapis/python-datacatalog/commit/b51902e26d590f52c9412756a178265850b7d516)) ##### Bug Fixes - **datacatalog:** deprecate resource name helper methods (via synth) ([#9831](https://www.github.com/googleapis/python-datacatalog/issues/9831)) ([22db3f0](https://www.github.com/googleapis/python-datacatalog/commit/22db3f0683b8aca544cd96c0063dcc8157ad7335)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

* Add samples for Data Catalog lookup_entry [(#2148)](GoogleCloudPlatform/python-docs-samples#2148) * Add samples for Data Catalog lookup_entry * Add tests for Data Catalog lookup_entry * Add samples for lookup_entry by SQL Resource * Add README.rst * Improve command line interface * Removed the "lookup-" prefix from commands * Handle the --sql-resource optional argument by subparsers * Refer to GCP public assets in tests * Add region tags to support Data Catalog docs [(#2169)](GoogleCloudPlatform/python-docs-samples#2169) * Adds updates including compute [(#2436)](GoogleCloudPlatform/python-docs-samples#2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Auto-update dependencies. [(#2005)](GoogleCloudPlatform/python-docs-samples#2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com> * chore(deps): update dependency google-cloud-datacatalog to v0.6.0 [(#3069)](GoogleCloudPlatform/python-docs-samples#3069) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-datacatalog](https://togithub.com/googleapis/python-datacatalog) | minor | `==0.5.0` -> `==0.6.0` | --- ### Release Notes <details> <summary>googleapis/python-datacatalog</summary> ### [`v0.6.0`](https://togithub.com/googleapis/python-datacatalog/blob/master/CHANGELOG.md#060httpswwwgithubcomgoogleapispython-datacatalogcomparev050v060-2020-02-24) [Compare Source](https://togithub.com/googleapis/python-datacatalog/compare/v0.5.0...v0.6.0) ##### Features - **datacatalog:** add sample for create a fileset entry quickstart ([#9977](https://www.github.com/googleapis/python-datacatalog/issues/9977)) ([16eaf4b](https://www.github.com/googleapis/python-datacatalog/commit/16eaf4b16cdc0ce7361afb1d8dac666cea2a9db0)) - **datacatalog:** undeprecate resource name helper methods, bump copyright year to 2020, tweak docstring formatting (via synth) ([#10228](https://www.github.com/googleapis/python-datacatalog/issues/10228)) ([84e5e7c](https://www.github.com/googleapis/python-datacatalog/commit/84e5e7c340fa189ce4cffca4fdee82cc7ded9f70)) - add `list_entry_groups`, `list_entries`, `update_entry_group` methods to v1beta1 (via synth) ([#6](https://www.github.com/googleapis/python-datacatalog/issues/6)) ([b51902e](https://www.github.com/googleapis/python-datacatalog/commit/b51902e26d590f52c9412756a178265850b7d516)) ##### Bug Fixes - **datacatalog:** deprecate resource name helper methods (via synth) ([#9831](https://www.github.com/googleapis/python-datacatalog/issues/9831)) ([22db3f0](https://www.github.com/googleapis/python-datacatalog/commit/22db3f0683b8aca544cd96c0063dcc8157ad7335)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency google-cloud-datacatalog to v0.7.0 [(#3320)](GoogleCloudPlatform/python-docs-samples#3320) Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> * Update Data Catalog samples to V1 [(#3382)](GoogleCloudPlatform/python-docs-samples#3382) Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(deps): update dependency google-cloud-datacatalog to v0.8.0 [(#3850)](GoogleCloudPlatform/python-docs-samples#3850) * Update dependency google-cloud-datacatalog to v1 [(#4115)](GoogleCloudPlatform/python-docs-samples#4115) * chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <coleleah@google.com> * Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390) * chore: update templates * chore: update templates * feat: Migrate to use Microgenerator * feat: Migrate to use Microgenerator * feat: Migrate to use Microgenerator * Migrate API to microgenerator * Migrate API to microgenerator * Samples tests * fix samples tests * fix lint errors and test coverage metrics * docs update * fix docs * fix docs * fix docs * remove .python-version file Co-authored-by: Ricardo Mendes <50331050+ricardosm-cit@users.noreply.github.com> Co-authored-by: Gus Class <gguuss@gmail.com> Co-authored-by: DPEBot <dpebot@google.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Marcelo Costa <mycelo19@gmail.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Leah Cole <coleleah@google.com>

daspecster and others added 11 commits February 14, 2017 08:28

Vision 1.1 add image url support (#233)

5a91bfa

Fixes #233.

Vision add crop hints detection. (#230)

12b332b

Vision add web image detection. (#231)

01476af

Vision 1.1 add full document text detection (#232)

742d419

Merge branch 'master' into vision-master-wip

7dcdf4c

Address float precision issues in tests.

d921ba4

Update to the vision proto/gapic.

766f34f

Rename Web Annotation to Web Detection. (#241)

28c4e4d

Remove vendored GAPIC.

3402c50

Remove tox dependency on vendored GAPIC.

e775efe

Make the linter happy.

f9821bd

lukesneeringer self-assigned this Feb 25, 2017

lukesneeringer requested review from daspecster and dhermes February 25, 2017 02:25

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 25, 2017

lukesneeringer added api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 25, 2017

Fix unit test failures caused by merge.

2c71e8d

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 25, 2017

lukesneeringer added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 25, 2017

daspecster reviewed Feb 25, 2017

View reviewed changes

docs/vision-usage.rst Outdated

@@ -317,6 +341,43 @@ Multiple images can be processed with a single request by passing

<Likelihood.VERY_LIKELY: 'POSSIBLE'>

***************

Web Annotations

This comment was marked as spam.

Sign in to view

daspecster suggested changes Feb 25, 2017

View reviewed changes

tox.ini Outdated

@@ -270,6 +270,8 @@ commands =

{[testing]localdeps}

python {toxinidir}/system_tests/attempt_system_tests.py {posargs}

deps =

{toxinidir}/_vendor/proto-google-cloud-vision-v1

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 25, 2017

daspecster approved these changes Feb 25, 2017

View reviewed changes

Make the linter happy, round 2.

0fe388d

lukesneeringer force-pushed the vision-master-wip branch from 6af45c5 to 0fe388d Compare February 25, 2017 03:57

daspecster added 2 commits February 24, 2017 23:22

Update vision-usage to 'Web Detection'

3220f6f

Remove _vendor deps.

889a538

lukesneeringer added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 25, 2017

lukesneeringer merged commit f4cb0ee into master Feb 25, 2017

lukesneeringer deleted the vision-master-wip branch February 25, 2017 05:57

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Vision 1.1 API Client (googleapis#3069)

e9ca7f9

parthea pushed a commit that referenced this pull request Oct 21, 2023

Vision 1.1 API Client (#3069)

83a0b98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vision 1.1 API Client #3069

Vision 1.1 API Client #3069

lukesneeringer commented Feb 25, 2017

googlebot commented Feb 25, 2017

This comment was marked as spam.

daspecster commented Feb 25, 2017

This comment was marked as spam.

This comment was marked as spam.

daspecster commented Feb 25, 2017 •

edited

Loading

daspecster commented Feb 25, 2017

daspecster commented Feb 25, 2017

daspecster commented Feb 25, 2017

lukesneeringer commented Feb 25, 2017

lukesneeringer commented Feb 25, 2017

lukesneeringer commented Feb 25, 2017

theacodes commented Feb 27, 2017

gguuss commented Feb 27, 2017

lukesneeringer commented Feb 27, 2017

Vision 1.1 API Client #3069

Vision 1.1 API Client #3069

Conversation

lukesneeringer commented Feb 25, 2017

googlebot commented Feb 25, 2017

This comment was marked as spam.

daspecster commented Feb 25, 2017

This comment was marked as spam.

This comment was marked as spam.

daspecster commented Feb 25, 2017 • edited Loading

daspecster commented Feb 25, 2017

daspecster commented Feb 25, 2017

daspecster commented Feb 25, 2017

lukesneeringer commented Feb 25, 2017

lukesneeringer commented Feb 25, 2017

lukesneeringer commented Feb 25, 2017

theacodes commented Feb 27, 2017

gguuss commented Feb 27, 2017

lukesneeringer commented Feb 27, 2017

daspecster commented Feb 25, 2017 •

edited

Loading