Spanner, BigQuery, Core, Error Reporting, Logging formatting style updates. #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
approved these changes
Feb 17, 2017
There was a problem hiding this comment.
LGTM pending CI (which is currently red).
@daspecster I am all for this kind of work, but it is somewhat all for naught if we don't have some kind of lint rule to keep it from happening again. (Not that it needs to go in this PR, just worth noting.)
| self, | ||
| make_client): | ||
| def test_report_exception_with_service_version_in_constructor(self, | ||
| make_client): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This looks interesting but it's a flake8 plugin. |
|
Ah, I forgot to rebase that last commit out. Crap. |
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…art-1 Spanner, BigQuery, Core, Error Reporting, Logging formatting style updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just changing /_makeOne/_make_one`/ and adding a space after the imports of unit_tests.