Skip to content

Conversation

theacodes
Copy link
Contributor

@theacodes theacodes commented Feb 9, 2017

Resolves #1240

(Aside: wow this code is complicated)

@theacodes theacodes added the api: storage Issues related to the Cloud Storage API. label Feb 9, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2017
@theacodes theacodes changed the title Storage resumable Add create_resumable_upload_session Feb 9, 2017
headers = {
'Accept': 'application/json',
'Accept-Encoding': 'gzip, deflate',
'User-Agent': connection.USER_AGENT,

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor Author

@dhermes or @tseaver do either of you want to take a look at this before I merge?

@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2017

I have lots of faith in @lukesneeringer

@theacodes
Copy link
Contributor Author

@lukesneeringer tests are failing because of the operations/protobuf issue? any recommendations?

@lukesneeringer
Copy link
Contributor

I know what needs to happen here; it is related to googleapis/api-client-staging#159.
I will have an update in half an hour.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Feb 9, 2017

I assert that this commit on googleapis/api-client-staging#159 fixes the issue; attempting tests locally to prove it before cutting a release to PyPI.

@lukesneeringer
Copy link
Contributor

@jonparrott I merged that other PR and pushed it to PyPI; your tests should pass now (or if they fail, it will be for other reasons ;-)).

@daspecster
Copy link
Contributor

I restarted the build.

@daspecster
Copy link
Contributor

Seems to have done the trick!

@theacodes theacodes merged commit 9619004 into googleapis:master Feb 9, 2017
@theacodes theacodes deleted the storage-resumable branch February 9, 2017 23:55
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants