Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to acknowledge 0 messages #2879

Merged
merged 2 commits into from
Dec 16, 2016
Merged

Do not attempt to acknowledge 0 messages #2879

merged 2 commits into from
Dec 16, 2016

Conversation

quom
Copy link
Contributor

@quom quom commented Dec 16, 2016 •
edited by daspecster
Loading

Closes #2878

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 16, 2016
@quom
Copy link
Contributor Author

quom commented Dec 16, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 16, 2016
@daspecster daspecster changed the title Closes #2878 Check if instantiated before acknowledging. Dec 16, 2016
@daspecster
Copy link
Contributor

@quom I tried to change the title of the PR to be more descriptive but I may have missed the mark. If you have better wording feel free to update!

@quom quom changed the title Check if instantiated before acknowledging. Do not attempt to acknowledge 0 messages Dec 16, 2016
@quom
Copy link
Contributor Author

quom commented Dec 16, 2016

Updated it a bit - should have done something similar first time

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Dec 16, 2016
@tseaver tseaver merged commit a514703 into googleapis:master Dec 16, 2016
@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2016

@quom Thanks very much for the patch!

@dhermes dhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull request googleapis#2879 from quom/master
fc6e118 
Do not attempt to acknowledge 0 messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quom @googlebot @daspecster @tseaver