Updating list_metrics() to Iterator pattern. #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
logging-iterators-metrics
branch
2 times, most recently
from
fc6e57f
to
5b33597
Compare
|
@daspecster @tseaver PTAL |
|
pyilnt failure: |
dhermes
force-pushed
the
logging-iterators-metrics
branch
from
5b33597
to
ce40029
Compare
|
Ahhhh! Darn rebases. PTAL. Was that your only issue? |
|
I didn't really review it in detail since Travis was red. |
|
OK well it's good to go now. LMK what you think |
tseaver
reviewed
Nov 1, 2016
| returned = { | ||
| 'metrics': METRICS, | ||
| } | ||
| client.connection = _Connection(returned) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| token = iterator.next_page_token | ||
|
|
||
| # First check the token. | ||
| self.assertIsNone(token) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
logging-iterators-metrics
branch
from
ce40029
to
9cf835c
Compare
|
@tseaver PTAL |
tseaver
approved these changes
Nov 1, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…rics Updating list_metrics() to Iterator pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2651 as diffbase. Unit test changes will be forthcoming.