Mention that cors property has a setter. #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Do you want to add docs for the |
|
@mlissner, I think that will be a separate PR actually. |
dhermes
reviewed
Oct 26, 2016
|
|
||
| See: http://www.w3.org/TR/cors/ and | ||
| https://cloud.google.com/storage/docs/json_api/v1/buckets | ||
|
|
||
| :setter: Set CORS policies for this bucket. | ||
| :getter: Gets the CORS policies for this bucket. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I'm generating the docs real quick and I'll screenshot it. |
|
|
|
Got it, so they aren't official directives but they are "generally supported" syntax |
|
👍 |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…s-docstring Mention that cors property has a setter.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bucket CORS property docs only say retrieve but it actually has a setter as well.
See #1838.