Moving to iterators in DNS. #2532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
dns-iterators
branch
from
ffca8d8 to
87c1bcc
Compare
Contributor
Author
|
@daspecster @tseaver @jonparrott PTAL. There will be about 5 more PRs like this for each package which does page token |
theacodes
approved these changes
Oct 17, 2016
Contributor
theacodes
left a comment
theacodes
left a comment
There was a problem hiding this comment.
Looks pretty straightforward to me.
Contributor
Author
|
TRAVIS! |
Contributor
No travis for you, I used up all of his cycles in |
Contributor
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2531 as diffbase.In doing this, I realized it's a bit tedious to have to write two classes (page and iterator) for each method. It may be more user-friendly to collapse back into one class. I think I could do it mostly by just making anything that is accessed viaself.page.fooasself.page_foo.