Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move monitoring code into a subpackage #2430

Merged
merged 2 commits into from
Sep 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 26, 2016

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-monitoring-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package monitoring \
  --package-name "Stackdriver Monitoring" \
  --readme "${READMES_DIR}/monitoring/README.rst"

@dhermes dhermes added packaging api: monitoring Issues related to the Cloud Monitoring API. labels Sep 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016

::

$ pip install --upgrade google-cloud-monitoring

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes force-pushed the make-monitoring-subpackage branch 2 times, most recently from 2c28250 to e2a394e Compare September 26, 2016 21:49
Done via:

$ mkdir -p monitoring/google/cloud
$ cp google/__init__.py monitoring/google/__init__.py
$ git add monitoring/google/__init__.py
$ cp google/cloud/__init__.py monitoring/google/cloud/__init__.py
$ git add monitoring/google/cloud/__init__.py
$ git mv google/cloud/monitoring monitoring/google/cloud/monitoring
$ git mv unit_tests/monitoring monitoring/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-monitoring as a dependency to the umbrella
  package
- Adding the monitoring subdirectory into the list of packages
  for verifying the docs
- Incorporating the monitoring subdirectory into the umbrella
  coverage report
- Adding the monitoring only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the monitoring
  tox config
@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

Rebased on top of #2435.

Green build

@dhermes dhermes merged commit 011e56d into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-monitoring-subpackage branch September 26, 2016 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants