Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vision image properties #2320

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Vision image properties #2320

merged 1 commit into from
Sep 15, 2016

Conversation

daspecster
Copy link
Contributor

@daspecster daspecster commented Sep 15, 2016 •
edited
Loading

Based from #2319

Adds the image properties detection API for Vision.

This adds a fairly large ImagePropertiesAnnotation with several classes to absorb the color data in the response.

✅ Also after #2319 is merged I will clean up the weird commit history.

@daspecster daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2016
@daspecster daspecster mentioned this pull request Sep 15, 2016
Merged
@daspecster daspecster force-pushed the vision-image-properties branch 2 times, most recently from 71f4e4b to e99b0e2 Compare September 15, 2016 17:52
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 15, 2016
@daspecster
Copy link
Contributor Author

@tseaver, I cleaned this up so it should be ready to checkout as well.

tseaver
tseaver reviewed Sep 15, 2016
View reviewed changes
google/cloud/vision/color.py

@property
def red(self):
"""Red color.

This comment was marked as spam.

Sign in to view

google/cloud/vision/color.py
return self._red

@property
def green(self):

This comment was marked as spam.

Sign in to view

google/cloud/vision/color.py
"""
return self._green

@property

This comment was marked as spam.

Sign in to view

google/cloud/vision/color.py

:type red: int
:param red: The amount of red in the color as a value in the interval
[0, 1].

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/cloud/vision/color.py
:param color: RGB components of the color.

:type score: float
:param score: Image-specific score for this color. Value in range [0, 1].

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

unit_tests/vision/_fixtures.py
}
}
]
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor Author

@tseaver, updated everything except the score docstring. That value is copied from their docs, but I can't seem to find a better explanation of it.

@tseaver
Copy link
Contributor

tseaver commented Sep 15, 2016

LGTM

@daspecster daspecster merged commit 0f5d982 into googleapis:master Sep 15, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster daspecster deleted the vision-image-properties branch January 24, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

Assignees

@tseaver tseaver

Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daspecster @tseaver @googlebot