Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 7, 2016

Broken after #2223.

  • Namespace packages break use of 'Client' from package.
  • Shorten bucket / topic names to match limits.
  • Stop sharing sink / metric names across tests (brush clearing to find the real issue with bucket / topic names).

- Namespace packages break use of 'Client' from package.

- Shorten bucket / topic names to match limits.

- Stop sharing sink / metric names across tests.
@tseaver tseaver added testing api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2016
@daspecster
Copy link
Contributor

LGTM pending travis!

@tseaver
Copy link
Contributor Author

tseaver commented Sep 7, 2016

Travis will pass for the PR (only changes to system_tests/), but fail on merge (due to other #2259 issues).

@tseaver tseaver merged commit 2499735 into googleapis:master Sep 7, 2016
@tseaver tseaver deleted the pubsub-logging-post-2223-system-tests branch September 7, 2016 18:38
@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants