Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing analyze sentiment method and helpers in language #2189

Merged
merged 3 commits into from
Aug 26, 2016
Merged

Implementing analyze sentiment method and helpers in language #2189

merged 3 commits into from
Aug 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 24, 2016 •
edited
Loading

NOTE: Has #2187 as diffbase.

tseaver
tseaver reviewed Aug 24, 2016
View reviewed changes
gcloud/language/sentiment.py

:type polarity: float
:param polarity: Polarity of the sentiment in the ``[-1.0, 1.0]`` range.
Larger numbers represent more positive sentiments.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Aug 24, 2016 •
edited
Loading

c70c471 looks fine, except for the (API-induced) confustion between polarity and magnitude. We may not be able to fix the conceptual issue, but maybe the docs have some words about the ideas?

e8b1b0f is fine.

6c4b6ef looks fine: the last assertion looks like it could be either too broad (to avoid flaky failures).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2016
@tseaver
Copy link
Contributor

tseaver commented Aug 25, 2016

LGTM once the docstring for sentiment includes a link to the concept docs.

@dhermes dhermes merged commit a3f6353 into googleapis:master Aug 26, 2016
@dhermes dhermes deleted the language-impl-5 branch August 26, 2016 20:04
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @tseaver @jerjou @daspecster @googlebot